Fix ambiguous SymbolDisplay reference in DecoratorGenerator #102
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI build failure due to missing SymbolDisplay reference
Fix ambiguous SymbolDisplay reference in DecoratorGenerator
Jan 29, 2026
JerrettDavis
approved these changes
Jan 30, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Test Results273 tests 273 ✅ 33s ⏱️ Results for commit b404e53. ♻️ This comment has been updated with latest results. |
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 82.49% 87.38% +4.89%
==========================================
Files 164 166 +2
Lines 15331 15767 +436
Branches 2122 2199 +77
==========================================
+ Hits 12647 13778 +1131
+ Misses 2129 1989 -140
+ Partials 555 0 -555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@copilot There are still test failures. https://github.com/JerrettDavis/PatternKit/actions/runs/21466441265/job/61954121408?pr=102 Please resolve. |
Contributor
Author
I investigated the test failures but all 1791 tests pass locally when I build and test both the base commit and this PR branch. I cannot access the detailed CI logs to see which specific tests are failing in the GitHub Actions environment. This suggests the failures might be:
I'll push an empty commit to trigger a clean CI rebuild and see if that resolves the issue. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
Code Coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to fix CI build failure
SymbolDisplay.FormatPrimitive()is ambiguous betweenMicrosoft.CodeAnalysis.SymbolDisplayandMicrosoft.CodeAnalysis.CSharp.SymbolDisplayMicrosoft.CodeAnalysis.CSharp.SymbolDisplay.FormatPrimitive()Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.