Skip to content

fix: issues property shouldBeginGestureHandler may be empty #17 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lforme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: issues property shouldBeginGestureHandler may be empty #17 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Source/SwiftyStarRatingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public typealias SSRVGestureHandler = (_ gesture: UIGestureRecognizer) -> Bool
public class SwiftyStarRatingView: UIControl {

public var shouldBecomeFirstResponder: Bool = false
public var shouldBeginGestureHandler: SSRVGestureHandler!
public var shouldBeginGestureHandler: SSRVGestureHandler?

fileprivate var _minimumValue: CGFloat = 0
fileprivate var _maximumValue: CGFloat = 5
Expand Down Expand Up @@ -310,7 +310,8 @@ extension SwiftyStarRatingView {
if let gestureView = gestureRecognizer.view, gestureView.isEqual(self) {
return !self.isUserInteractionEnabled
} else {
return self.shouldBeginGestureHandler(gestureRecognizer)
guard let handle = self.shouldBeginGestureHandler else { return false }
return handle(gestureRecognizer)
}
}

Expand Down
8 changes: 8 additions & 0 deletions SwiftyStarRatingView.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>IDEDidComputeMac32BitWarning</key>
<true/>
</dict>
</plist>