Skip to content

Conversation

@Elizaveta239
Copy link

@Elizaveta239 Elizaveta239 commented Dec 16, 2025

…ted abstractions from agents

Motivation and Context

Currently, we (EmbArk) have a dependency on Code Engine's module ai.jetbrains.code.files:code-files-model, which is rather small module for working with files and filesystem. But the problem is that it has dependencies on one class from koog: ai.koog.agents.ext.tool.file.filter.GlobPattern which is located in ai.koog:agents-ext and adds dependencies on many various koog-related modules (and even on ktor-server).

So I moved GlobPattern.kt, FileSize.kt, FileSystemEntry.kt and FileSystemEntryBuilders.kt from ai.koog:agents-ext to rag:rag-base module.

Breaking Changes


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Qodana for JVM

1177 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 1157
Missing KDoc for public API declaration 🔶 Warning 20
@@ Code coverage @@
+ 72% total lines covered
17738 lines analyzed, 12845 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Elizaveta239 Elizaveta239 marked this pull request as ready for review December 16, 2025 15:56
@Elizaveta239 Elizaveta239 requested a review from kpavlov January 7, 2026 08:35
Elizaveta239 and others added 2 commits January 9, 2026 14:01
Co-authored-by: Konstantin Pavlov <1517853+kpavlov@users.noreply.github.com>
@Elizaveta239 Elizaveta239 force-pushed the liza/agents-ext-refactor branch from cf30df8 to 7ea5142 Compare January 9, 2026 13:04
@Elizaveta239
Copy link
Author

Updated to the fresh develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants