Skip to content

Conversation

@Joe-Thompson
Copy link
Owner

No description provided.

Joe-Thompson and others added 4 commits June 2, 2019 21:26
Still working on adding in some of the strech tasks, but wanted to get something in before tonight.  I wasnt sure on how to exactly submit the project so I am taking a stab doing it this way.

Co-Authored-By: Joe Alfaro <josephlalfaro@gmail.com>
Co-Authored-By: Joe Alfaro <josephlalfaro@gmail.com>
@Joe-Thompson Joe-Thompson requested a review from Joe-Alfaro June 3, 2019 23:25
Copy link
Collaborator

@Joe-Alfaro Joe-Alfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the html. I think you divided up the page really well. A couple of small things, the links in the navbar can be set up to jump to the content they are related to. You would add an id to the content and then the anchor tag href would equal #id. This is one of the only acceptable uses of id's. Since you have the image in the nav tag it should also be an anchor and can just have href=# to refresh the homepage. Also the anchor tags you have for telephone and email in the footer wouldn't work as is. They href's have a special syntax and you should look them up just to be familiar.

Copy link
Collaborator

@Joe-Alfaro Joe-Alfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS is great! Your page looks so good, I don't think I did better when I did this. Fantastic, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants