Skip to content

Debouncer class name conflicts with dedicated Debouncer libraries #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rcbadiale wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −4
Open

Debouncer class name conflicts with dedicated Debouncer libraries #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf9d70d
Rename class Debouncer to avoid conflicts
Sep 25, 2020
7bc78f6
Update README.md
rcbadiale Sep 25, 2020
7ddd5a2
Revert "Update README.md"
Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Encoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void Encoder::init()

void Encoder::compute()
{
static Debouncer stDebouncer, pDebouncer;
static EncoderDebouncer stDebouncer, pDebouncer;

byte eA = !digitalRead( _pinA );
byte eB = !digitalRead( _pinB );
Expand Down Expand Up @@ -181,7 +181,7 @@ void computeEncoder()
EncoderInterrupt.computeAll();
}

bool Debouncer::isDebounced( byte value, byte debounceCount)
bool EncoderDebouncer::isDebounced( byte value, byte debounceCount)
{
if ( _keepValue != value )
{
Expand Down
4 changes: 2 additions & 2 deletions Encoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ class EncoderInterruptClass
friend void computeEncoder();
};

class Debouncer
class EncoderDebouncer
{
private:
byte _keepValue;
byte _bounce;

public:
Debouncer():_keepValue(0), _bounce(0) {}
EncoderDebouncer():_keepValue(0), _bounce(0) {}
bool isDebounced( byte value, byte debounceCount);
};

Expand Down