Added a property that turn on/off gzip compression of css and js files.#7
Open
sboyina wants to merge 4 commits intoJonathanWalsh:masterfrom
Open
Added a property that turn on/off gzip compression of css and js files.#7sboyina wants to merge 4 commits intoJonathanWalsh:masterfrom
sboyina wants to merge 4 commits intoJonathanWalsh:masterfrom
Conversation
If suppose, gzip compression is turned on server for all the css files and granule combined css file can not be omitted from this compression. gzip compression happens two times, and the combined css / js files may not work as expected. So, there must be an option in granule to turn off gzip compression. a property called gzip.output is added to configuration. By default this value is set to true. If granule gzip compression is not required, then this parameter has to be set to false.
Reverted the earlier fix and made a change to decompress gzip output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If suppose, gzip compression is turned on server for all the css files
and granule combined css file can not be omitted from this compression.
gzip compression happens two times, and the combined css / js files may
not work as expected. So, there must be an option in granule to turn
off gzip compression. a property called gzip.output is added to
configuration. By default this value is set to true. If granule gzip
compression is not required, then this parameter has to be set to false.