-
Notifications
You must be signed in to change notification settings - Fork 5
add crc cluster install/delete role and gitaction #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
372801e
add crc cluster install/delete role and gitaction
Jooho b82839e
Merge branch 'main' into crc_install
Jooho 6681b55
fix Makefile
Jooho c5a6075
Merge remote-tracking branch 'refs/remotes/origin/crc_install' into c…
Jooho 1010b6f
fix Makefile
Jooho c45f3d5
remove gitaction for crc check
Jooho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,30 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Launch Package", | ||
| "type": "go", | ||
| "request": "launch", | ||
| "mode": "auto", | ||
| "program": "${fileDirname}", | ||
| "env": { | ||
| "POD_NAMESPACE": "kserve" | ||
| } | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Python Debugger: Current File", | ||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "program": "${workspaceFolder}/cmd/loopy.py", | ||
| "console": "integratedTerminal", | ||
| "env": { "PYTHONPATH": "src" }, | ||
| // "args": ["roles", "run", "shell-execute", "-p", "COMMANDS=echo test"] | ||
| "args": ["roles", "run", "openshift-local-install", "-g"] | ||
| // "args": ["units", "run", "loopy-roles-test-non-cluster-shell-execute"] | ||
| }, | ||
|
|
||
| { | ||
| "name": "Attach to Loopy", | ||
| "type": "debugpy", | ||
| "request": "attach", | ||
| "connect": { | ||
| "host": "localhost", | ||
| "port": 5678 | ||
| }, | ||
| { | ||
| "name": "Debug Ginkgo Test(inferenceservice)", | ||
| "type": "go", | ||
| "request": "launch", | ||
| "mode": "auto", | ||
| "program": "${workspaceFolder}/pkg/controller/v1beta1/inferenceservice/rawkube_controller_test.go", | ||
| "args": [ | ||
| "-ginkgo.v", | ||
| "-ginkgo.focus", "When creating inference service with raw kube predictor with workerSpec" | ||
| ], | ||
| "env": { | ||
| "KUBEBUILDER_ASSETS": "/home/jooho/.local/share/kubebuilder-envtest/k8s/1.29.5-linux-amd64" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Debug Ginkgo Test(inferenceGraph)", | ||
| "type": "go", | ||
| "request": "launch", | ||
| "mode": "auto", | ||
| "program": "${workspaceFolder}/pkg/controller/v1alpha1/inferencegraph/", | ||
| "args": ["-ginkgo.v"], | ||
| "env": { | ||
| "KUBEBUILDER_ASSETS": "/home/jooho/.local/share/kubebuilder-envtest/k8s/1.29.5-linux-amd64" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
|
|
||
| "justMyCode": false | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directory glob has a typo – tests will be skipped unintentionally
cluster-life-cycle≠cluster-lifecycle. The current regex never matches the actual paths, so the workflow always short-circuits.Make the same correction in the commented-out OpenShift block below.
📝 Committable suggestion
🤖 Prompt for AI Agents