update main.js - tooltip - data toggle attribute#115
Open
pepperstreet wants to merge 1 commit intoJoomShaper:masterfrom
Open
update main.js - tooltip - data toggle attribute#115pepperstreet wants to merge 1 commit intoJoomShaper:masterfrom
pepperstreet wants to merge 1 commit intoJoomShaper:masterfrom
Conversation
Since Helix3 has been upgraded to Bootstrap v5, it needs the correct data toggle for the tooltip initialization. data-bs-toggle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Helix3 has been upgraded to Bootstrap v5, it needs the correct data toggle for the tooltip initialization. data-bs-toggle
But I am totally confused about your Helix3 overrides and the main.js
For instance the BLOG overrides (meta data above articles) have a ToolTip display.
But they use the "older" Bootstrap3 syntax for the attributes!?
Is this on purpose?
Why does it work anyway?
Since you have switched to Bootstrap v5, shouldn't it be used in all places? Including your overrides and layouts etc. ?
Sure, I see the tedious work. If you would change the initialization script in main.js, you end up with changing all occurrences in every single override ;)
Looks like a Chicken-Egg-Situation?