Skip to content

Added support for instagram social icon #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imarklee wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for instagram social icon #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a89f73
Added support for instagram social icon
imarklee Nov 27, 2017
c8c6c1d
Fixed issue with helix css compressor when dealing with certain relat…
imarklee Dec 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion plugins/system/core/helix3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,15 @@ function ($matches)
$base = dirname($base);
$url = substr($url, 3);
}
$url = $base . '/' . $url;

// If the base is always /, it shouldn't be adding another /
$default = $base . '/' . $url;

if ($base === '/') {
$default = '/' . $url;
}

$url = $default;

return "url('$url')";
}, $compressed);
Expand Down
2 changes: 2 additions & 0 deletions template/en-GB.tpl_shaper_helix3.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ HELIX_SOCIAL_ICON_VK="VK Username"
HELIX_SOCIAL_ICON_VK_DESC="Input the full URL to your VK profile page."
HELIX_SOCIAL_ICON_CUSTOM="Custom"
HELIX_SOCIAL_ICON_CUSTOM_DESC="Insert your custom url with fontawesome icon, eg. fa-facebook http://joomshaper.com"
HELIX_SOCIAL_ICON_INSTAGRAM="Instagram URL"
HELIX_SOCIAL_ICON_INSTAGRAM_DESC="Input the full URL to your Instagram page."

;Contact Info
HELIX_CONTACT_INFO="Contact Information"
Expand Down
6 changes: 6 additions & 0 deletions template/features/social.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public function renderFeature() {
$flickr = $this->helix3->getParam('flickr');
$vk = $this->helix3->getParam('vk');
$custom = $this->helix3->getParam('custom');
$instagram = $this->helix3->getParam('instagram');

if( $this->helix3->getParam('show_social_icons') && ( $facebook || $twitter || $googleplus || $pinterest || $youtube || $linkedin || $dribbble || $behance || $skype || $flickr || $vk ) ) {
$html = '<ul class="social-icons">';
Expand Down Expand Up @@ -71,6 +72,11 @@ public function renderFeature() {
if( $skype ) {
$html .= '<li><a href="skype:'. $skype .'?chat"><i class="fa fa-skype"></i></a></li>';
}

if ($instagram) {
$html .= '<li><a href="' . $instagram . '"><i class="fa fa-instagram"></i></a></li>';
}

if( $whatsapp ) {
$html .= '<li><a href="whatsapp://send?abid='. $whatsapp .'&text=Hi"><i class="fa fa-whatsapp"></i></a></li>';
}
Expand Down
Loading