fix: getModules method returns duplicated entries#410
Open
yyasinaslan wants to merge 1 commit intoJoomShaper:devfrom
Open
fix: getModules method returns duplicated entries#410yyasinaslan wants to merge 1 commit intoJoomShaper:devfrom
yyasinaslan wants to merge 1 commit intoJoomShaper:devfrom
Conversation
Some information added to module selection view so user will know which module is published and its id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an issue in the module selection process within the megamenu builder. The getModules method in the Helper.php file was returning duplicate entries. This problem was caused by a join statement involving the extensions table, which can contain entries with the same name for both admin and site contexts.
Additionally, I have added information to the module selection view to indicate which modules are published and display their respective IDs.