Skip to content

enhanced subtitle parser#88

Open
spyderbibek wants to merge 1 commit intoJoran-Dob:mainfrom
spyderbibek:webvttparserfix
Open

enhanced subtitle parser#88
spyderbibek wants to merge 1 commit intoJoran-Dob:mainfrom
spyderbibek:webvttparserfix

Conversation

@spyderbibek
Copy link

Description

Rewrote the parsing functionality to be more concise and easier to read also created a helper function _parseTime to parse the time components and construct the Duration objects.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@spyderbibek spyderbibek requested a review from Joran-Dob as a code owner April 13, 2024 15:35
@spyderbibek
Copy link
Author

Fixes Issue #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant