Remove the listener from the video player controller in case the cont…#94
Open
pdurasie-ecovery wants to merge 1 commit intoJoran-Dob:mainfrom
Open
Conversation
…roller's life cycle is longer than the bloc's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the listener from the video player controller in case the controller's life cycle is longer than the bloc's.
Description
Fixes issue #92 . The problem arises when the video player controller continues to be used but the widget containing a subtitle bloc is disposed. The bloc will be closed due to the widget's disposal, but the video player controller will still update and call the listener, which leads to "cannot emit state after calling close".
Type of Change