Skip to content

don't crash QN processor on unknown proposal type #5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdembler wants to merge 1 commit into
base: petra
Choose a base branch
from
Open

don't crash QN processor on unknown proposal type #5172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions query-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### 2.4.0

- Bump @joystream/types to Petra version
- Don't crash QN processor on unknown proposal type

### 2.2.1

Expand Down
3 changes: 2 additions & 1 deletion query-node/mappings/src/proposals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ import {
genericEventFields,
getByIdOrFail,
getWorkingGroupModuleName,
logger,
toNumber,
unimplementedError,
unwrap,
Expand Down Expand Up @@ -366,7 +367,7 @@ async function parseProposalDetails(
details.remoteChains = unwrap(bridgeConstraints.remoteChains)?.map((a) => a.toNumber())
return details
} else {
unimplementedError(`Unsupported proposal details type: ${proposalDetails.type}`)
logger.error(`Unsupported proposal details type: ${proposalDetails.type.toString()}`)
}
}

Expand Down