Skip to content

Fix sub url paths not working when serving atlas using caddy #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
freakstatic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sub url paths not working when serving atlas using caddy #284

freakstatic wants to merge 1 commit into from

Conversation

@freakstatic
Copy link

@freakstatic freakstatic commented Dec 26, 2023

Urls like /marketplace and /discover were returning 404

@freakstatic
Copy link
Author

freakstatic commented Dec 26, 2023

@ignazio-bovo can you please review?

@mnaamani mnaamani requested review from dobertRowneySr, kdembler, mnaamani and zeeshanakram3 and removed request for kdembler January 3, 2024 10:36
kdembler
kdembler approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kdembler
kdembler approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdembler kdembler kdembler approved these changes

@zeeshanakram3 zeeshanakram3 Awaiting requested review from zeeshanakram3

@dobertRowneySr dobertRowneySr Awaiting requested review from dobertRowneySr

@mnaamani mnaamani Awaiting requested review from mnaamani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@freakstatic @kdembler