CT-3129 Payment Methods Landscape Insets #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/white" | ||
| android:fitsSystemWindows="true"> |
Contributor
Author
There was a problem hiding this comment.
We already are setting this on outer layer, which is appBar in payment_methods_fragment.
RafalOzogJudopay
force-pushed
the
CT-3129-payment-methods-landscape-insets
branch
from
53b8998 to
7476ed0
Compare
RafalOzogJudopay
force-pushed
the
CT-3129-payment-methods-landscape-insets
branch
from
0b37ddf to
bc7e994
Compare
RafalOzogJudopay
force-pushed
the
CT-3129-payment-methods-landscape-insets
branch
from
253602e to
b4572e8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fixes insets in Payment Methods landscape mode.
Background (in case of no payment method state), and app bar horizontal line stretch to the very edges, as the background should, but the content respects insets (has correct margins).
2. Fixed PM collapsing toolbar behaviour in landscape.
I have simplified previously made solution that was calculating min height for toolbar (in landscape) as percentage of the screen height. It wasn't working well for all screen sizes and fonts, sometimes certain elements were overlapping, sometimes hidden on some screens, sometimes not (collapsing is controlled by Android through the CollapsingToolbarLayout).
Instead I simplified it to the fixed height dimen (as we have in portrait), but added offsetChangeListener (in PMFragment), which is ensuring that in landscape, certain elements are hidden when the toolbar is collapsed.
3. Works if we rotate screen either left or right.
Demo:
Before:
Video: demoBefore.webm
After:
Video: demoAfter.webm