Conversation
|
The name is really bad. Should we change it to |
|
I’d like to add that the protobuf utils will be in the second level as I think both util functions in the second level should actually be in the fourth selectingChannel :: Word16 -> Prism' Packet PacketAdditionally, you didn’t apply all the arguments to |
I don't think all code in the library has to be separated into the different levels. For me, it's just a way to create some sort of order in our implementation of the specs.
Agreed! I'll change those things right now. |
|
What's @lukasepple's opinion on this so far? |
|
Maybe the code on channels should be replaced by a link to the implementation #52? |
|
The more parts of the proposal I implemented on |
|
Shouldn't we just merge this? |
|
Level two implements the parsing of raw |
|
Parsing protobuf messages is in level three though, so what’s new in level four?
|
This PR will serve as the thread for the discussion of the contents of this proposal.