Skip to content

[CI] Use init_worker_code to reduce testset initialization overhead #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christiangnrd wants to merge 4 commits into
base: master
Choose a base branch
from
+21 −9
Open

[CI] Use init_worker_code to reduce testset initialization overhead #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2761800
Remove unused Pkg dependency
christiangnrd Feb 4, 2026
3001b2f
Remove forced concurrency on macOS
christiangnrd Feb 4, 2026
d999163
Adapt to `init_worker_code`
christiangnrd Jan 28, 2026
723e4df
Allow 1.13 tests to fail
christiangnrd Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ steps:
- "1.10"
- "1.12"
- "1.13"
adjustments:
- with:
julia: "1.13"
soft_fail: true
soft_fail:
- exit_status: 3

Expand Down Expand Up @@ -101,6 +105,10 @@ steps:
- "1.10"
- "1.12"
- "1.13"
adjustments:
- with:
julia: "1.13"
soft_fail: true
soft_fail:
- exit_status: 3

Expand Down Expand Up @@ -154,6 +162,10 @@ steps:
- "1.10"
- "1.12"
- "1.13"
adjustments:
- with:
julia: "1.13"
soft_fail: true
soft_fail:
- exit_status: 3

Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ jobs:
run: |
# Run tests in verbose mode
TEST_ARGS=(--verbose)
if [[ ${{ runner.os }} == "macOS" ]]; then
# Encourage ParallelTestRunner to use two jobs on macOS, rather
# than the single one it'd use by default.
TEST_ARGS+=(--jobs=2)
fi
echo "runtest_test_args=${TEST_ARGS[@]}" >> "${GITHUB_ENV}"
- uses: julia-actions/julia-runtest@v1
continue-on-error: ${{ matrix.version == 'nightly' }}
Expand Down
3 changes: 1 addition & 2 deletions test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@ JLD2 = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
KernelAbstractions = "63c18a36-062a-441e-b654-da1e3ab1ce7c"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
ParallelTestRunner = "d3525ed8-44d0-4b2c-a655-542cee43accc"
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[compat]
ParallelTestRunner = "2"
ParallelTestRunner = "2.2"
10 changes: 8 additions & 2 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import GPUArrays

include("testsuite.jl")

const init_code = quote
const init_worker_code = quote
using Test, JLArrays, SparseArrays

include("testsuite.jl")
Expand All @@ -18,11 +18,17 @@ const init_code = quote
end
end

const init_code = quote
using Test, JLArrays, SparseArrays

import ..TestSuite
end

args = parse_args(ARGS)

testsuite = Dict{String, Expr}()
for AT in (:JLArray, :Array), name in keys(TestSuite.tests)
testsuite["$(AT)/$name"] = :(TestSuite.tests[$name]($AT))
end

runtests(GPUArrays, ARGS; init_code, testsuite)
runtests(GPUArrays, ARGS; init_code, init_worker_code, testsuite)
Loading