Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #755 +/- ##
==========================================
- Coverage 74.75% 73.54% -1.22%
==========================================
Files 24 24
Lines 3672 3791 +119
==========================================
+ Hits 2745 2788 +43
- Misses 927 1003 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if llvm_func_idx[] == -1 | ||
| continue | ||
| end |
|
That said, all this complexity is there to be able to populate the compilation database. If we're fine with simply passing the entry-point CI to Can this be simplified on the Enzyme.jl end? Why does it need exact correlation between LLVM functions and their MI/CI? |
|
No we need to retain the MI for each llvm function in order to determine where to apply custom rules, what types correspond to which LLVM args/instructions, among other things. |
see #754