Merged
Conversation
Julia 1.14 asserts that CodeInfo.edges is Union{Nothing, SimpleVector, Vector{Any}}.
Change from Vector{MethodInstance} to Vector{Any} for compatibility.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Julia 1.14 asserts that CodeInfo.edges is Union{Nothing, SimpleVector, Vector{Any}}.
Change from Vector{MethodInstance} to Vector{Any} for compatibility.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Julia 1.14 generates different IR for keyword arguments, containing inttoptr and jl_f_apply_type calls. Skip this test on 1.14 until the Julia behavior is investigated. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/jlgen.jl b/src/jlgen.jl
index 29e54f5..b006220 100644
--- a/src/jlgen.jl
+++ b/src/jlgen.jl
@@ -135,7 +135,7 @@ function methodinstance_generator(world::UInt, source, self, ft::Type, tt::Type)
# propagate edge metadata
new_ci.min_world = min_world[]
new_ci.max_world = max_world[]
- new_ci.edges = Any[mi]
+ new_ci.edges = Any[mi]
# prepare the slots
new_ci.slotnames = Symbol[Symbol("#self#"), :ft, :tt]
@@ -627,14 +627,14 @@ function ci_cache_populate(interp, cache, mi, min_world, max_world)
end
@static if VERSION >= v"1.14-"
-function ci_cache_lookup(cache, mi, min_world, max_world)
- # In Julia 1.14+, WorldView was replaced by InternalCodeCache with WorldRange
- # cache is OverlayCodeCache{InternalCodeCache}, extract owner from globalcache
- owner = cache.globalcache.owner
- wvc = CC.InternalCodeCache(owner, CC.WorldRange(min_world, max_world))
- ci = CC.get(wvc, mi, nothing)
- return ci
-end
+ function ci_cache_lookup(cache, mi, min_world, max_world)
+ # In Julia 1.14+, WorldView was replaced by InternalCodeCache with WorldRange
+ # cache is OverlayCodeCache{InternalCodeCache}, extract owner from globalcache
+ owner = cache.globalcache.owner
+ wvc = CC.InternalCodeCache(owner, CC.WorldRange(min_world, max_world))
+ ci = CC.get(wvc, mi, nothing)
+ return ci
+ end
else
function ci_cache_lookup(cache, mi, min_world, max_world)
wvc = WorldView(cache, min_world, max_world)
diff --git a/test/native.jl b/test/native.jl
index 9f908dc..33363a3 100644
--- a/test/native.jl
+++ b/test/native.jl
@@ -643,12 +643,12 @@ end
end
Base.Experimental.@MethodTable method_table
- # @consistent_overlay (Julia 1.11+) is needed for the compiler to optimize through the overlay
- @static if VERSION >= v"1.11-"
- Base.Experimental.@consistent_overlay method_table @noinline Core.throw_inexacterror(f::Symbol, ::Type{T}, val) where {T} = return
- else
- Base.Experimental.@overlay method_table @noinline Core.throw_inexacterror(f::Symbol, ::Type{T}, val) where {T} = return
- end
+ # @consistent_overlay (Julia 1.11+) is needed for the compiler to optimize through the overlay
+ @static if VERSION >= v"1.11-"
+ Base.Experimental.@consistent_overlay method_table @noinline Core.throw_inexacterror(f::Symbol, ::Type{T}, val) where {T} = return
+ else
+ Base.Experimental.@overlay method_table @noinline Core.throw_inexacterror(f::Symbol, ::Type{T}, val) where {T} = return
+ end
end
@test @filecheck begin |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 74.75% 75.30% +0.55%
==========================================
Files 24 24
Lines 3672 3677 +5
==========================================
+ Hits 2745 2769 +24
+ Misses 927 908 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
FYI JuliaLang/julia#59413 was marked for backporting a few days ago so this will probably have to be adjusted once 1.13.0-beta2 is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.