Skip to content

Fix typed pointer gv initialization #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchuravy merged 5 commits into from
Jan 20, 2026
Merged

Fix typed pointer gv initialization #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64f3476
Fix typed pointer gv initialization
wsmoses Jan 20, 2026
5246e46
Also actually do a best effort initialization
wsmoses Jan 20, 2026
6c30d7c
fix
wsmoses Jan 20, 2026
37b655b
fmt
wsmoses Jan 20, 2026
75c5ee3
Change condition to check for LLVM.ConstantInt
wsmoses Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/jlgen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,20 @@ function compile_method_instance(@nospecialize(job::CompilerJob))
continue
end
gv_to_value[LLVM.name(gv)] = C_NULL
val = initializer(gv)
if val === nothing
continue
end
while isa(val, LLVM.ConstantExpr)
if in(opcode(val), (LLVM.API.LLVMBitCast, LLVM.API.LLVMPtrToInt, LLVM.API.LLVMAddrSpaceCast, LLVM.API.LLVMIntToPtr))
val = operands(val)[1]
continue
end
break
end
if isa(val, LLVM.ConstantInt)
gv_to_value[LLVM.name(gv)] = reinterpret(Ptr{Cvoid}, convert(UInt, val))
end
end
else
@assert inits !== nothing
Expand All @@ -855,7 +869,7 @@ function compile_method_instance(@nospecialize(job::CompilerJob))
# set the initializer
# TODO(vc): To enable full relocation we should actually strip out the initializers here.
if LLVM.isnull(initializer(gv))
val = const_inttoptr(ConstantInt(Int64(init)), LLVM.PointerType())
val = const_inttoptr(ConstantInt(Int64(init)), value_type(initializer(gv)))
initializer!(gv, val)
end
end
Expand Down
3 changes: 3 additions & 0 deletions test/native.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ end

if VERSION >= v"1.12"
@test length(meta.gv_to_value) == 1
for (k, v) in meta.gv_to_value
@test v != C_NULL
end
end
# TODO: Global values get privatized, so we can't find them by name anymore.
# %.not = icmp eq ptr %"sym::Symbol", inttoptr (i64 140096668482288 to ptr), !dbg !38
Expand Down