Skip to content

[Metal] sincos parameter attributes #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christiangnrd wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −11
Open

[Metal] sincos parameter attributes #762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c894b
[Metal] Add sincos parameter attributes
christiangnrd Jan 27, 2026
66dffe8
`add_attributes` -> `add_fn_attributes`
christiangnrd Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions src/metal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,45 +1002,57 @@ function annotate_air_intrinsics!(@nospecialize(job::CompilerJob), mod::LLVM.Mod
isdeclaration(f) || continue
fn = LLVM.name(f)

attrs = function_attributes(f)
function add_attributes(names...)
fn_attrs = function_attributes(f)
function add_fn_attributes(names...)
for name in names
if LLVM.version() >= v"16" && name in ["argmemonly", "inaccessiblememonly",
"inaccessiblemem_or_argmemonly",
"readnone", "readonly", "writeonly"]
# XXX: workaround for changes from https://reviews.llvm.org/D135780
continue
end
push!(attrs, EnumAttribute(name, 0))
push!(fn_attrs, EnumAttribute(name, 0))
end
changed = true
end

function add_param_attributes(idx, names...)
param_attrs = parameter_attributes(f, idx)
for name in names
push!(param_attrs, EnumAttribute(name, 0))
end
changed = true
end

# synchronization
if fn == "air.wg.barrier" || fn == "air.simdgroup.barrier"
add_attributes("nounwind", "mustprogress", "convergent", "willreturn")
add_fn_attributes("nounwind", "mustprogress", "convergent", "willreturn")

# sincos
elseif match(r"^air.sincos", fn) !== nothing
add_param_attributes(2, "nocapture", "writeonly")

# atomics
elseif match(r"air.atomic.(local|global).load", fn) !== nothing
# TODO: "memory(argmem: read)" on LLVM 16+
add_attributes("argmemonly", "readonly", "nounwind")
add_fn_attributes("argmemonly", "readonly", "nounwind")
elseif match(r"air.atomic.(local|global).store", fn) !== nothing
# TODO: "memory(argmem: write)" on LLVM 16+
add_attributes("argmemonly", "writeonly", "nounwind")
add_fn_attributes("argmemonly", "writeonly", "nounwind")
elseif match(r"air.atomic.(local|global).(xchg|cmpxchg)", fn) !== nothing
# TODO: "memory(argmem: readwrite)" on LLVM 16+
add_attributes("argmemonly", "nounwind")
add_fn_attributes("argmemonly", "nounwind")
elseif match(r"^air.atomic.(local|global).(add|sub|min|max|and|or|xor)", fn) !== nothing
# TODO: "memory(argmem: readwrite)" on LLVM 16+
add_attributes("argmemonly", "nounwind")
add_fn_attributes("argmemonly", "nounwind")

# simdgroup
elseif match(r"air.simdgroup_matrix_8x8_multiply_accumulate", fn) !== nothing
add_attributes("convergent", "mustprogress", "nounwind", "willreturn")
add_fn_attributes("convergent", "mustprogress", "nounwind", "willreturn")
elseif match(r"air.simdgroup_matrix_8x8_load", fn) !== nothing
add_attributes("convergent", "mustprogress", "nofree", "nounwind", "readonly", "willreturn")
add_fn_attributes("convergent", "mustprogress", "nofree", "nounwind", "readonly", "willreturn")
elseif match(r"air.simdgroup_matrix_8x8_store", fn) !== nothing
add_attributes("convergent", "mustprogress", "nounwind", "willreturn", "writeonly")
add_fn_attributes("convergent", "mustprogress", "nounwind", "willreturn", "writeonly")
end
end

Expand Down
Loading