[Feature] Ability to set initial accumulated plastic strain#184
[Feature] Ability to set initial accumulated plastic strain#184mitchellmcm27 wants to merge 7 commits intoJuliaGeodynamics:mainfrom
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
use if-blocks to set Phases, Temp, and APS
|
It would also be good if you can fix the test; seems to break in |
|
OK @boriskaus there seems to be an issue with some versions of GMT.jl (or maybe ultimately GMT itself). The test essentially reads a geotiff file and extracts the value at a specific point. When I activate Project.toml with Reading and plotting the tif file with test2 = import_GeoTIFF("test_files/UTM2GTIF.TIF"
heatmap(convert(GeoData,test2),field=:layer1, colormap = :grays, colorrange = (0, 255)
If I update GMT in Project.toml to
I'm not sure which specific version of GMT has the bug, but maybe we should update the dependency to 1.35? I can do that in this PR if you want. |
|
Can confirm that all of tests pass with GMT 1.35.0. |
Fixes reading geotiff files
|
Yes sure. Limiting the GMT version is the better way to go |
|
Looks like some of the tests failed to download the topo data from GMT. Maybe a temporary issue? Is there a way to rerun the tests after some time? |
|
Yes you can rerun failed ones |
1.15.1 evidently had a bug reading geotiffs. Confirmed 1.17 does not have this bug.
|
OK, I found that GMT 1.17 resolves the bug reading the geotiff, so relaxed the version range. |


I want to add the ability to set the initial APS, similar to how we can set the initial temperature and phases on the domain. Although pretty simple, this feature involves coordinated PRs in LaMEM, LaMEM.jl and GeophysicalModelGenerator.jl (see below). The changes are meant to be fully backwards compatible. I am leaving this as a draft as I want to get some feedback on the approach.
For more details, see the PR in the LaMEM repo (UniMainzGeo/LaMEM#41)
Summary of changes
LaMEM.jl (JuliaGeodynamics/LaMEM.jl#92)
plast_strainas a cross-section (name matches Paraview field)out_ptr_APSoption to include APS on passive tracers (defaults to 0)GeophysicalModelGenerator.jl (this PR)
LaMEM (UniMainzGeo/LaMEM#41)