Draft
Conversation
sbromberger
reviewed
Feb 17, 2020
Contributor
sbromberger
left a comment
sbromberger
left a comment
There was a problem hiding this comment.
Looks like a very good start. I think we're going to need some tests as well.
| @@ -0,0 +1,218 @@ | |||
| # This file is machine-generated - editing it directly is not advised | |||
Contributor
There was a problem hiding this comment.
We don't need Manifest.toml in the repo... you should add this to .gitignore.
| return 1 | ||
| end | ||
|
|
||
| savegraph(io::IO, g::AbstractGraph, gname::String, ::GEXFFormat) = savegexf(io, g, gname) |
Contributor
There was a problem hiding this comment.
I think we still need this since without it we won't be able to save non-Metagraphs.
|
|
||
| using GraphIO.EzXML | ||
| using LightGraphs | ||
| using MetaGraphs |
Contributor
There was a problem hiding this comment.
I don't think we need this here since you're including metagraphs.jl below, which has it.
| xattrs = addelement!(xg, "attributes") | ||
| xattrs["class"] = element_type | ||
| for (k,i) in k2id | ||
| xat=addelement!(xattrs, "attribute") |
| end | ||
| end | ||
|
|
||
| function savegexf(io::IO, g::MetaGraph, gname::String) |
Contributor
There was a problem hiding this comment.
Should this be MetaGraph or AbstractMetaGraph? Is it just for undirected metagraphs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the export to Metagraphs. I also add Project.tom. I would appreciate little shepherding to finish this to a PR.