fix precision of non-integer power#227
Merged
JeffreySarnoff merged 5 commits intoJuliaMath:mainfrom Feb 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 49.20% 49.17% -0.04%
==========================================
Files 63 63
Lines 3410 3406 -4
==========================================
- Hits 1678 1675 -3
+ Misses 1732 1731 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
thank you. |
Contributor
Author
|
It was in the line 124 of the file src/math/elementary/explog.jl:
it is not there anymore because I deleted it, as it became unnecessary due to the cutoff I introduced in the size of the exponent. Now I just take |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When raising an integer to
DoubleFloatpower precision was lost, because thelogwas computed as aFloat64. This PR fixes this.Before the PR:
After the PR:
A bit unrelated, but why are you converting to
Float64before converting toInt64here?