Use explicit imports #156
Merged
Use explicit imports #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The windows failure is some issue with libfftw3-3.dll unrelated to this PR |
Collaborator
|
@JeffFessler, thanks for showing me ExplicitImports.jl, that's a really neat package! I think it would be good if all the import/using statements are bundled in the main NFFTTools.jl file if possible. Otherwise, I think we'd have to consider the order of include statements in the main file when looking at the individual files |
Collaborator
Author
|
ok, i bundled them all into NFFTTools.jl while also leaving them (inside block comments) within the individual jl files to provide some guidance to people who look at an individual file. seem ok? |
Collaborator
|
@JeffFessler yes, looks good to me, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make some additions / improvements to the density compensation code.
I found the existing code hard to follow because it uses implicit imports.
With the help of ExplicitImports.jl, I found the origins of all of the functions being used, and then modified the code to use explicit imports. This PR will help future developers (including me) more easily find the sources.
I made a related PR at FFTW.jl so that ExplicitImports.jl gives this (sub)repo a clean pass:
JuliaMath/FFTW.jl#329
@nHackel would you be able to review?