Open
Conversation
Member
|
yeah - not sure - doing some other refactoring so i will check this one. in theory should be fine, |
Contributor
Author
|
You should not merge it into main yet. I used the changes on a work project earlier this week. It removes config values and converts incorrectly on¨some properties during an umbraco 8 migration (eg mediapicker -> mediaPicker3) - because these migrators only handle "prevalues" and not config. |
Member
|
Yes, increasingly i am thinking there are two categories of migration, a) hard v7 ones, I am sort of aiming for splitting thigns a little bit, so in theory we can have the 'less hard' v8 stuff happen in a way that means we can us it in uSync proper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the "default" version to support both 7 and 8. Because the version is set to 7 - most of the converteres are not used.
I am aware that this may not be the desired logic - alternatively, the version must be set on all migrators that are desired for 7 or 8.