Skip to content

Conversation

@pixelflips
Copy link
Member

Description

Updates the tertiary button hover state to use --pine-color-background-muted (grey-150) instead of --pine-color-background-subtle (grey-100) for both background and border colors.

This change provides better visual contrast for the tertiary button hover state, improving user feedback when interacting with tertiary buttons.

No new dependencies required.

Fixes DSS-41

Type of change

  • Styling only fix

How Has This Been Tested?

  • tested manually

Test Configuration:

  • Pine versions: latest
  • OS: macOS
  • Browsers: Chrome
  • Screen readers: N/A
  • Misc: Visual inspection of tertiary button hover states

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Dec 15, 2025
@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit ab51800
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/69407fc2a153fa00089ea6ba
😎 Deploy Preview https://deploy-preview-613--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the package: core Changes have been made to the Core package label Dec 15, 2025
@pixelflips pixelflips marked this pull request as ready for review December 15, 2025 21:38
@pixelflips
Copy link
Member Author

@cameronsimony you can use the preview netlify link above to review the hover color update.

Copy link

@cameronsimony cameronsimony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixelflips pixelflips merged commit 4f1457b into main Dec 16, 2025
15 checks passed
@pixelflips pixelflips deleted the style/tertiary-button-hover branch December 16, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants