fix(pds-modal): make border prop mutable and remove debug logging #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the
pds-modal-contentcomponent by removing debug console.log statements and fixing Stencil prop mutability warnings.Changes:
console.logstatements that were outputting scroll/border state information to the consolemutable: trueto theborderprop decorator to fix Stencil warnings about modifying an immutable prop from within the componentThe
borderprop is dynamically updated based on scroll position when not explicitly set by the user, which requires the prop to be mutable. Without this flag, Stencil was logging repeated warnings in the console.Fixes DSS-48
Type of change
How Has This Been Tested?
Verified that console warnings and debug logs no longer appear when interacting with the modal component. Existing modal tests are unaffected as they do not test the
borderprop or console output.Test Configuration:
Checklist: