Skip to content

Conversation

@pixelflips
Copy link
Member

Description

Cleans up the pds-modal-content component by removing debug console.log statements and fixing Stencil prop mutability warnings.

Changes:

  • Removed 7 debug console.log statements that were outputting scroll/border state information to the console
  • Added mutable: true to the border prop decorator to fix Stencil warnings about modifying an immutable prop from within the component

The border prop is dynamically updated based on scroll position when not explicitly set by the user, which requires the prop to be mutable. Without this flag, Stencil was logging repeated warnings in the console.

Fixes DSS-48

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Verified that console warnings and debug logs no longer appear when interacting with the modal component. Existing modal tests are unaffected as they do not test the border prop or console output.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions: N/A
  • OS: macOS
  • Browsers: Chrome
  • Screen readers: N/A
  • Misc: N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Dec 18, 2025
@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 1dd8a06
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/69447da390b6dd000818093f
😎 Deploy Preview https://deploy-preview-616--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Dec 18, 2025
@pixelflips pixelflips marked this pull request as ready for review December 18, 2025 22:18
@pixelflips pixelflips merged commit e7170a2 into main Dec 18, 2025
15 checks passed
@pixelflips pixelflips deleted the fix/modal-logs-warnings branch December 18, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants