Skip to content

Conversation

@pixelflips
Copy link
Member

Description

Standardizes helper and error message typography across form components to ensure visual consistency.

Changes:

  • pds-input: Updated helper/error message font from --pine-typography-body-sm to --pine-typography-body-sm-medium
  • pds-checkbox: Removed custom font-size override on error message (now inherits --pine-typography-body-sm-medium)
  • pds-checkbox: Changed error message gap from --pine-dimension-050 to --pine-dimension-2xs

These components now match the typography used by pds-textarea, pds-select, and pds-switch.

Fixes DSS-49

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Dec 18, 2025
@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 676984c
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/694480dc8ade1700087247e8
😎 Deploy Preview https://deploy-preview-617--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the package: core Changes have been made to the Core package label Dec 18, 2025
@pixelflips pixelflips marked this pull request as ready for review December 18, 2025 22:32
@pixelflips pixelflips merged commit a19de8e into main Dec 18, 2025
23 of 24 checks passed
@pixelflips pixelflips deleted the style/input-helper-weight branch December 18, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants