Conversation
kjavaherpour
left a comment
kjavaherpour
left a comment
There was a problem hiding this comment.
This looks good! What else is needed from prebid for this?
Just the documentation which is here KargoGlobal/prebid.github.io#1 |
andyrusiecki
left a comment
andyrusiecki
left a comment
There was a problem hiding this comment.
This looks great! Just have a few suggestions for the extensions.
static/bidder-params/kargo.json
Outdated
| } | ||
| }, | ||
|
|
||
| "required": ["tagid"] |
There was a problem hiding this comment.
If replacing this extension with adSlot then we can make it optional. Kraken already supports mapping an Imp's TagID (along with the Site.Id) to a Kargo ad slot, but having an explicit adSlot ext field would be more reliable if set.
There was a problem hiding this comment.
I believe prebid sets this field as required, so it either needs to specify a parameter or have no parameters. If adSlot is optional, then this field should be left empty since Prebid Server Core will discard them.
| "secure": 1, | ||
| "iframebuster": ["ALL"], | ||
| "ext": { | ||
| "adSlotID": "11523" |
There was a problem hiding this comment.
Each impression will have an Imp.Ext.adSlotID and a Imp.tagid. Since the adSlotID is now required by Prebid S2S, Kraken can check this instead of appending "siteID" + . + "tagId" as shown here for Prebid requests:
| "cat": ["IAB13"], | ||
| "w": 300, | ||
| "h": 300, | ||
| "ext": {"mediaType": "banner"} |
There was a problem hiding this comment.
We will now be sending the mediaType back to prebid as it is required by the adapter
|
@ssadman22 We can close this - right? |
6 participants
The Prebid PR exists here: #1
Prebid Kargo Readme: KargoGlobal/prebid.github.io#1
KRAK-3623 Add a prebid s2s adapter to the open source prebid repo
Based on the Prebid guide: https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html
Most of the code here is generic except for the unit tests and configs.