Javac extension #3686
Draft
Javac extension #3686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadoon
reviewed
Nov 24, 2025
| // this is needed to be able to load checker framework checkers in the javac | ||
| // extension | ||
| jvmArgs += [ | ||
| "--add-exports", |
Member
There was a problem hiding this comment.
This requirement makes this PR unusable in practice. The normal execution is java -jar key-...-exe.jar.
Using start scripts, it would be possible, but #3638 is not discussed.
| * @return future providing the list of diagnostics | ||
| */ | ||
| public static @NonNull CompletableFuture<List<PositionedIssueString>> check( | ||
| ProblemInitializer.ProblemInitializerListener listener, | ||
| Path bootClassPath, List<Path> classPath, Path javaPath) { | ||
| File bootClassPath, List<File> classPath, File javaPath, | ||
| List<String> processors) { |
Member
There was a problem hiding this comment.
Should it not be JavacSettings instance here for later extensibility?
…figuration" This reverts commit 74af1d7.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3686 +/- ##
=========================================
Coverage 47.99% 47.99%
Complexity 16046 16046
=========================================
Files 1683 1683
Lines 96044 96044
Branches 15387 15387
=========================================
+ Hits 46093 46095 +2
+ Misses 44681 44680 -1
+ Partials 5270 5269 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
in KeY. This includes creating settings for the Javac Extension, to be able to set the checkers.
version.
Type of pull request
Ensuring quality
.github/workflows/tests.ymlAdditional information and contact(s)
@WolframPfeifer is involved in this pull request.
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.