Script improvement #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update the python script for generating the string file from swift source. Now, it supports generating string from multiple inputs. The usage is similar to the Apple's genstrings tool. Usage: find /path/to/source -iname "*.swift" | xargs python ./genstrings_swift.py -o ./App/en.lproj/ ./App/Source/LocalizationConstants.swift 2. Fix the bug in python script for merging the string file. When the string value contains escaped double quotes, it will be excluded from the string file. For example, following lines will be striped from the final output /* String with quotes */ "EscapedQuotes" = "\"String with quotes\"";
Contributor
|
Thank you. We try to look into it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, it supports generating string from multiple inputs. The usage is
similar to the Apple's genstrings tool.
Usage: find /path/to/source -iname "*.swift" | xargs python ./genstrings_swift.py -o ./App/en.lproj/ ./App/Source/LocalizationConstants.swift
value contains escaped double quotes, it will be excluded from the string
file. For example, following lines will be striped from the final output
/* String with quotes */
"EscapedQuotes" = ""String with quotes"";