[Hackathon] Add accessibility checker to editor#3023
Draft
mark-fitzgerald wants to merge 17 commits intomainfrom
Draft
[Hackathon] Add accessibility checker to editor#3023mark-fitzgerald wants to merge 17 commits intomainfrom
mark-fitzgerald wants to merge 17 commits intomainfrom
Conversation
…ditor panel. Update Issues panel to display Alerts in addition to Warnings. Send axe-core results to Issues panel.
…ht element with the issue.
…which issues are user-fixable so that content creators know that they should send us the info. Update color tokens to use the correct tokens (status is being deprecated).
Contributor
🗄️ Schema Change: No Changes ✅ |
… instead of JSON.
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +1.92 kB (+0.39%) Total Size: 500 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (b5ac29d) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3023If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3023If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3023 |
…eft cell of the editor is stacked above the right cell so that the Show Me outline is visible. Adjust axe-core configuration to only scan the preview iFrame that is visible when editing, not the one that is in the "Preview" tab (both are rendered in the page).
… frame has rendered before running axe-core.
…t still have to render, even though they have been "loaded" from an event listener standpoint.
…, and adjust timing for post-loaded retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: