Revert "Resolving the cursor jumping in the Editor bug (#2976)"#3072
Open
SonicScrewdriver wants to merge 2 commits intomainfrom
Open
Revert "Resolving the cursor jumping in the Editor bug (#2976)"#3072SonicScrewdriver wants to merge 2 commits intomainfrom
SonicScrewdriver wants to merge 2 commits intomainfrom
Conversation
…t): Reverting Editor Cursor Bouncing Fix
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +42 B (+0.01%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c581947) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3072If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3072If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3072 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This reverts commit 9f9bb23, AKA the work that removed the Perseus-side debouncing. This is due to some issues with specific inputs in various widget editors experiencing a worsening of the issue, as they do not have a local state.
Test plan: