[Radio] Fix height difference when displaying NOTA (none of the above) radio choice#3195
[Radio] Fix height difference when displaying NOTA (none of the above) radio choice#3195
Conversation
…ce when displaying NOTA (none of the above) radio choice
…isplaying NOTA (none of the above) radio choice
🗄️ Schema Change: No Changes ✅ |
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: -10 B (0%) Total Size: 485 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (1bdb20e) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3195If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3195If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3195 |
| ? "correct" | ||
| : "wrong" | ||
| : undefined; | ||
| const content = choice.isNoneOfTheAbove |
There was a problem hiding this comment.
Removed the redundant NOTA content override that was replacing Renderer-wrapped content with a plain string
There was a problem hiding this comment.
If this change is kept, then there needs to be a way to ensure that this string is included in the choice content. The current usage of the NOTA in the editor is that the text is not editable. If I recall correctly, the content for a NOTA choice is an empty string.
There was a problem hiding this comment.
Currently, this code is ensuring that the NOTA option has been translated in a consistent manner. If this text is managed elsewhere, then it will need to ensure the same results.
| it("displays provided content for 'None of the above' choices", () => { | ||
| // The widget layer is responsible for setting the correct content | ||
| // for NOTA choices. The component just displays whatever content | ||
| // is passed to it. |
There was a problem hiding this comment.
If that is the case, then this test is not needed since there is no logic to test.
ivyolamit
changed the title
2 participants
Summary:
Fix height difference when displaying NOTA (none of the above) radio choice
Issue: LEMS-3664
Test plan: