Ensure we create a changeset for browserslist update PRs#3243
Ensure we create a changeset for browserslist update PRs#3243jeremywiebe wants to merge 1 commit intomainfrom
Conversation
…rslist update PRs
🗄️ Schema Change: No Changes ✅ |
|
Size Change: 0 B Total Size: 484 kB ℹ️ View Unchanged
|
🛠️ Item Splitting: No Changes ✅ |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (a19d6ec) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3243If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3243If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3243 |
Myranae
left a comment
There was a problem hiding this comment.
If what the browserslist supports is not something we use, then the minimum change to get things unblocked sooner sounds good. Would we be aware of issues related to min-browser changes? If there's a possibility that could lead to difficult to diagnose errors, then it might just be simpler to make sure all packages are patch bumped like you said, but this sounds like it's not a major concern.
Summary:
I noticed that the most recent Browserslist update PR was blocked because it was missing a changeset. I think we just want to have an empty changeset (ie. this update in itself would not trigger a package to be released).
We could argue the flipside which is that all packages should be patch-bumped if the browserslist is updated in
pnpm-lock.yamlbecause re-building the package could result in a different set of polyfills (due to min-browser changes).In reality, I think this might all be busywork as we don't use Babel's
preset-envwhich is what the browserslist database supports. 🤔Issue:
Test plan: