Skip to content

Ensure we create a changeset for browserslist update PRs#3243

Open
jeremywiebe wants to merge 1 commit intomainfrom
jer/browserslist-update-fix
Open

Ensure we create a changeset for browserslist update PRs#3243
jeremywiebe wants to merge 1 commit intomainfrom
jer/browserslist-update-fix

Conversation

@jeremywiebe
Copy link
Collaborator

Summary:

I noticed that the most recent Browserslist update PR was blocked because it was missing a changeset. I think we just want to have an empty changeset (ie. this update in itself would not trigger a package to be released).

We could argue the flipside which is that all packages should be patch-bumped if the browserslist is updated in pnpm-lock.yaml because re-building the package could result in a different set of polyfills (due to min-browser changes).

In reality, I think this might all be busywork as we don't use Babel's preset-env which is what the browserslist database supports. 🤔

Issue:

Test plan:

@github-actions
Copy link
Contributor

🗄️ Schema Change: No Changes ✅

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 484 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.8 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 98.5 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 11.8 kB
packages/perseus-core/dist/es/index.js 24.8 kB
packages/perseus-editor/dist/es/index.js 99.2 kB
packages/perseus-linter/dist/es/index.js 8.83 kB
packages/perseus-score/dist/es/index.js 9.26 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 187 kB
packages/perseus/dist/es/strings.js 7.44 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.71 kB

compressed-size-action

@github-actions
Copy link
Contributor

🛠️ Item Splitting: No Changes ✅

@github-actions
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (a19d6ec) and published it to npm. You
can install it using the tag PR3243.

Example:

pnpm add @khanacademy/perseus@PR3243

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3243

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3243

@jeremywiebe jeremywiebe marked this pull request as ready for review February 11, 2026 00:45
@jeremywiebe jeremywiebe added the project agnostic PRs reviewable by any Perseus team member label Feb 11, 2026
@jeremywiebe jeremywiebe requested review from a team February 11, 2026 00:45
Copy link
Contributor

@Myranae Myranae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If what the browserslist supports is not something we use, then the minimum change to get things unblocked sooner sounds good. Would we be aware of issues related to min-browser changes? If there's a possibility that could lead to difficult to diagnose errors, then it might just be simpler to make sure all packages are patch bumped like you said, but this sounds like it's not a major concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

olc-5.0.4f948 project agnostic PRs reviewable by any Perseus team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants