[WB-1998.3] Migrate color to semanticColor in math-input#3250
Open
jandrade wants to merge 3 commits intowb-color2sc-2from
Open
[WB-1998.3] Migrate color to semanticColor in math-input#3250jandrade wants to merge 3 commits intowb-color2sc-2from
jandrade wants to merge 3 commits intowb-color2sc-2from
Conversation
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +61 B (+0.01%) Total Size: 485 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (335f5c7) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3250If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3250If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3250 |
added 2 commits
February 12, 2026 10:52
…lor` tokens instead of the now deprecated WB color tokens.
jandrade
commented
Feb 12, 2026
| position: "relative", | ||
| borderStyle: "solid", | ||
| borderColor: color.offBlack50, | ||
| borderColor: semanticColor.core.border.neutral.default, |
Member
Author
There was a problem hiding this comment.
| ...(showInputFocusStyle | ||
| ? { | ||
| borderColor: color.blue, | ||
| borderColor: |
Member
Author
There was a problem hiding this comment.
| borderColor: semanticColor.core.border.neutral.default, | ||
| borderRadius: 4, | ||
| color: color.offBlack, | ||
| color: semanticColor.core.foreground.neutral.strong, |
Member
Author
There was a problem hiding this comment.
| width: "100%", | ||
| marginBottom: "1em", | ||
| border: `1px solid ${color.offBlack16}`, | ||
| border: `1px solid ${semanticColor.core.border.neutral.subtle}`, |
Member
Author
There was a problem hiding this comment.
| justifyContent: "center", | ||
| alignItems: "center", | ||
| boxShadow: `0px 1px 0px ${color.offBlack32}`, | ||
| boxShadow: `0px 1px 0px ${semanticColor.core.shadow.chonky.neutral.subtle}`, |
Member
Author
There was a problem hiding this comment.
note: I used a chonky shadow to match the Design specs: https://www.figma.com/design/HlLQJqNeMTLenuDfkyzYzE/Perseus-Widgets?node-id=2433-142&t=cCvcHm2aRBMF3G6d-4
https://khanacademy.atlassian.net/wiki/spaces/WB/pages/4049666283/Core#Neutral.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates the Aphrodite styles in
math-inputto the newsemanticColortokens.This PR is part of the larger effort to migrate the Perseus codebase to use the
new
semanticColortokens.Documents for reference:
Implementation plan:
Issue: https://khanacademy.atlassian.net/browse/WB-1998
Test plan:
Verify that the components in math-input look correct.