[Image] | (UX) | Scale up SVG images to fill screen when zoomed#3252
Open
[Image] | (UX) | Scale up SVG images to fill screen when zoomed#3252
Conversation
…screen when zoomed Currently, the zoomed view of an image will show it at its original/natural size. It was implemented this way so that the images are at their largest size without compromising quality, but that doesn't apply to SVGs. SVGs can be scaled up without quality drop. In this PR: - Scale up SVGs to fit the whole screen on zoom - Do not scale up non-SVGs on zoom - keep them at their natural size Issue: https://khanacademy.atlassian.net/browse/LEMS-3740 Test plan: `pnpm jest packages/perseus/src/widgets/image/image.test.ts` Storybook - `/?path=/story/widgets-image-widget-demo--graphie-image` - `/?path=/story/widgets-image-widget-demo--image`
…G images to fill screen when zoomed
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +88 B (+0.02%) Total Size: 484 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f422944) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3252If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3252If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3252 |
nishasy
commented
Feb 12, 2026
| /** | ||
| * When the content is at least as wide as the viewport (i.e. mobile), | ||
| * allow the content to fill the entire viewport. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
I was confused about what this meant, so I added a comment so it wouldn't confuse me again later.
nishasy
requested review from
catandthemachines and
ivyolamit
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, the zoomed view of an image will show it at its original/natural size.
It was implemented this way so that the images are at their largest size without compromising
quality, but that doesn't apply to SVGs. SVGs can be scaled up without quality drop.
In this PR:
Issue: https://khanacademy.atlassian.net/browse/LEMS-3740
Test plan:
pnpm jest packages/perseus/src/widgets/image/image.test.tsStorybook
/?path=/story/widgets-image-widget-demo--graphie-image/?path=/story/widgets-image-widget-demo--imageBefore
After