Draft
Conversation
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +110 B (+0.02%) Total Size: 484 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (58608da) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3253If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3253If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This adds a new API to widget editors that allows them to pre-populate widget options based on the context it's being added in.
Right now the only context is: what text is currently selected?
Right now the only widget behavior is: is text is selected when adding a Definition widget, use that text as the
togglePrompt.However this was built to facilitate future requests if the need arises.
Issue: LEMS-3560
Additional ideas:
static defaultProps: DefinitionDefaultWidgetOptions = definitionLogic.defaultWidgetOptions;stuff? All things should be going through the parser which should add defaults.getStartWidgetOptionsto all widget editors?getStartWidgetOptionsfrom the widget editor? We could use an editor registry instead.getDefaultWidgetOptionsapplyDefaultsToWidgetandapplyDefaultsToWidgetsRenderer._getInitialWidgetStateconst plotterDefaults = CoreWidgetRegistry.getDefaultWidgetOptions("plotter");could be refactored better.Test plan:
Screen.Recording.2026-02-13.at.2.41.45.PM.mov