Conversation
popescu-v
reviewed
Jan 26, 2026
popescu-v
reviewed
Jan 26, 2026
popescu-v
reviewed
Jan 26, 2026
popescu-v
reviewed
Jan 26, 2026
popescu-v
requested changes
Jan 26, 2026
added 2 commits
January 26, 2026 15:45
When a remote access test (s3, gcs) fails it leaves the env variables dirty. This impacts the subsequent tests. The cleaning cannot be done in a decorator because the execution flow is interrupted when the test fails. The best place for the cleaning is into the tearDown method.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix broken tests.
When a remote access test (s3, gcs) fails it leaves the env variables dirty. This impacts the subsequent tests.
The cleaning cannot be done in a decorator because the execution flow is interrupted when the test fails. The best place for the cleaning is into the
tearDownmethod.TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html