Conversation
Closed
popescu-v
reviewed
Feb 9, 2026
popescu-v
reviewed
Feb 9, 2026
popescu-v
reviewed
Feb 9, 2026
popescu-v
reviewed
Feb 9, 2026
Collaborator
popescu-v
left a comment
popescu-v
left a comment
There was a problem hiding this comment.
Shouldn't we also test the khisto- native packages in the CI (like we do for the khiops packages)?
See the other comments as well.
bruno-at-orange
force-pushed
the
915-add-khisto-packages
branch
3 times, most recently
from
bf1ef47 to
5487527
Compare
popescu-v
reviewed
Feb 11, 2026
popescu-v
reviewed
Feb 11, 2026
popescu-v
reviewed
Feb 11, 2026
popescu-v
reviewed
Feb 11, 2026
popescu-v
reviewed
Feb 11, 2026
popescu-v
reviewed
Feb 11, 2026
popescu-v
requested changes
Feb 11, 2026
bruno-at-orange
force-pushed
the
915-add-khisto-packages
branch
3 times, most recently
from
178e32d to
222e9f9
Compare
bruno-at-orange
force-pushed
the
915-add-khisto-packages
branch
from
222e9f9 to
4a8ca1f
Compare
Member
Author
|
khisto is tested in the |
popescu-v
reviewed
Feb 13, 2026
popescu-v
reviewed
Feb 13, 2026
popescu-v
reviewed
Feb 13, 2026
popescu-v
approved these changes
Feb 13, 2026
Collaborator
popescu-v
left a comment
popescu-v
left a comment
There was a problem hiding this comment.
LGTM, safe for a few comments:
- 2 details in the README that would better be fixed for accurracy IMHO
- 1 detail in the CI, which is not essential but is better to fix IMHO, so that the intention of the code is clear.
It was already installed
bruno-at-orange
force-pushed
the
915-add-khisto-packages
branch
from
3535740 to
46e4bda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.