Fix incorrect variable usage in MVKImagePlane::getMTLTexture()#2669
Merged
billhollings merged 1 commit intoKhronosGroup:mainfrom Dec 12, 2025
Merged
Fix incorrect variable usage in MVKImagePlane::getMTLTexture()#2669billhollings merged 1 commit intoKhronosGroup:mainfrom
MVKImagePlane::getMTLTexture()#2669billhollings merged 1 commit intoKhronosGroup:mainfrom
Conversation
`_mtlTexture` can still be nil at this point which means that we may have a memoryless texture attempt to get added to the residency set.
squidbus
approved these changes
Dec 4, 2025
billhollings
approved these changes
Dec 12, 2025
Contributor
billhollings
left a comment
billhollings
left a comment
There was a problem hiding this comment.
LGTM. Thanks for submitting!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_mtlTexturecan still be nil at this point which means that we may have a memoryless texture attempt to get added to the residency set.