Fix semantics of VK_KHR_present_wait.#2693
Open
kleinerm wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Fix semantics of VK_KHR_present_wait.#2693kleinerm wants to merge 1 commit intoKhronosGroup:mainfrom
kleinerm wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
The VK_KHR_present_wait spec states that the wait of vkWaitForPresent() should end
as close as possible to the point in time when the presented image for a presentID
becomes visible to the user ("first pixel visible").
This can be achived by calling _swapchain->notifyPresentComplete() from
MVKPresentableSwapchainImage::endPresentation(), ie from the Metal drawables
presentCompleted handler, after Metal signals present completion.
Right now, _swapchain->notifyPresentComplete() is called from the Metal command
buffers completedHandler(), ie. when the command buffer scheduling the present
completes. This typically happens multiple milliseconds before actual present, and
in case of presents scheduled via VK_GOOGLE_DISPLAY_TIMING far in the future,
there can be a long time between completedHandler() and actual present completion.
This commit moves the _swapchain->notifyPresentComplete() to the more appropriate
place, and behind _swapchain->endPresentation(), so if a client returns from a
call to vkWaitForPresent(), potentially queried VK_GOOGLE_DISPLAY_TIMING
presentation timestamps are already available for the client to fetch.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VK_KHR_present_wait spec states that the wait of vkWaitForPresent() should end as close as possible to the point in time when the presented image for a presentID becomes visible to the user ("first pixel visible").
This can be achived by calling _swapchain->notifyPresentComplete() from MVKPresentableSwapchainImage::endPresentation(), ie from the Metal drawables presentCompleted handler, after Metal signals present completion.
Right now, _swapchain->notifyPresentComplete() is called from the Metal command buffers completedHandler(), ie. when the command buffer scheduling the present completes. This typically happens multiple milliseconds before actual present, and in case of presents scheduled via VK_GOOGLE_DISPLAY_TIMING far in the future, there can be a long time between completedHandler() and actual present completion.
This commit moves the _swapchain->notifyPresentComplete() to the more appropriate place, and behind _swapchain->endPresentation(), so if a client returns from a call to vkWaitForPresent(), potentially queried VK_GOOGLE_DISPLAY_TIMING presentation timestamps are already available for the client to fetch.