rerun clang-format with 132 line width#233
Merged
spencer-lunarg merged 1 commit intoKhronosGroup:mainfrom Nov 18, 2023
Merged
Conversation
338a18d to
0b0625d
Compare
Contributor
|
Is there a specific reason why you want to override the Google style guide default for this? |
Contributor
Author
Comments like this or while subjective, I feel this is not easy to read and the style guide was always a "baseline" in my personal vision, we do this for the Validation Layers too also (subjective) I never understood why it was 80 char wide only to begin with |
cassiebeckley
approved these changes
Nov 18, 2023
Contributor
cassiebeckley
left a comment
There was a problem hiding this comment.
That's fair. I don't think we can override the style guide for internal projects at Google, but I have no personal objections to this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I plan after this lands to make a
.git-blame-ignore-revsfile with the commit, this way git blame on any modern git tool (and GitHub) will ignore this PR