dark mode css changes.

[gpx1000]

First attempt at changes to dark mode.

[Tobski]

Oh, hm, I approved the change but then realised this includes a bunch of other changes for like slang highlighting and such. Is that intentional?

Reason stated above

[SaschaWillems]

Slang highlight is something we need for the tutorial. Just gave this a quick test and this looks very good and a lot better than the current dark mode 👍🏻

[gpx1000]

@Tobski sadly it takes more than an hour to do a build, and I only have one place I can publish the build with github for free so if I want people to review, I either have to require they build locally or group changes, so there's rarely a time I don't have more than one change for everyone to test. Normal thing.

[oddhack]

@Tobski sadly it takes more than an hour to do a build, and I only have one place I can publish the build with github for free so if I want people to review, I either have to require they build locally or group changes, so there's rarely a time I don't have more than one change for everyone to test. Normal thing.

We should have a sandbox version of the site build that just includes a single document which exercises all the asciidoctor elements found across all the components, and can be selected in the manual Actions invocations (or maybe by branch name). Reviewing these changes is hard as it stands.

[gpx1000]

@Tobski sadly it takes more than an hour to do a build, and I only have one place I can publish the build with github for free so if I want people to review, I either have to require they build locally or group changes, so there's rarely a time I don't have more than one change for everyone to test. Normal thing.

We should have a sandbox version of the site build that just includes a single document which exercises all the asciidoctor elements found across all the components, and can be selected in the manual Actions invocations (or maybe by branch name). Reviewing these changes is hard as it stands.

That's what we have right now. If you go into CI and submit the form, you select what branch to build for each module including the headers and select the publish to github. That's how I generate the links for review. For this one the header changes path is gpx1000/antora-ui-khronos/css-style-changes-for-dark-mode If you want a specific commit, you can add it to the end of that with a # deliminator.
If you do that, then you can select which user/module/branch#commitHash for each module and the header then hit build. Then you can download the entire site from the assets that the CI produces and look at it locally.

We could break changes up to separate branches in the headers, and keep track of which goes with which issue making sure to take the header changes before we take these high level branches but most of those header changes will cause merge conflicts as they usually are the same files that get changed.

I'm certain there's easier ways to do this; but that's the architecture we have right now given the constraints of our architecture.

[oddhack]

That's what we have right now. If you go into CI and submit the form, you select what branch to build for each module including the headers and select the publish to github.

I just mean a single component with a single page with all the elements of interest as a test - would pass a different .yml file to antora, no need to pull GB of other repos, and take literally seconds to run instead of 20+ minutes.

[gpx1000]

hmm... I see what you're saying. Can I request we make an issue to track that request separately? I can whip something up along those lines. Maybe a antora template yml that is populated via the forms script from CI... Might even be able to craft a separate URL within the sandbox website for each item so whomever creates a build can copy the URL into the PR or issue to simply look at that.
I'll have to think a bit if there's a way to only pull the exact things needed and have the user specify them. Maybe make a template script that we use for each check-in.... I'll start thinking of a design.

[Tobski]

FWIW, from my review, I'm happy overall with the new color scheme, my only real complaint is that the hyperlink color is too dark now, compared to most dark mode themes (e.g. GitHub), and they do kind of melt into the background. To my eyes, the new theme is otherwise a lot easier on the eyes, but I can see how it's going to be a downgrade for anyone using high contrast settings generally.