Codeowner, stale-pr and codeql #16
Conversation
WalkthroughThree new configuration files have been added to the repository. A CODEOWNERS file designates @Thaleszh as the owner for all files. Two GitHub Actions workflows are introduced: one for CodeQL analysis, which runs on pushes and pull requests to the main branch, and another for managing stale pull requests, scheduled to run daily and also triggerable manually. The stale PR workflow uses the actions/stale@v9 action with a configuration that sets Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
.github/CODEOWNERS (1)
1-1: Single-owner rule looks good but consider redundancy.Relying on a single CODEOWNER means all reviews block on @Thaleszh’s availability. Adding a backup owner (team or second maintainer) prevents PR bottlenecks when the primary reviewer is unavailable.
.github/workflows/codeql.yml (2)
1-8: Trigger only onmainmay miss security findings for release branches.If you later introduce long-lived branches (e.g.
release/*ordevelop) they will not receive CodeQL scans. Consider broadening the branch filter or usingpush: { branches-ignore: [...] }.
9-15: Tighten default permissions.Granting
security-events: writeis required, butpackages: readis only needed when using private CodeQL packs. If you aren’t using them, drop this permission to follow the principle of least privilege..github/workflows/stale-pr.yml (1)
11-14: Explicitly configure PR stale/close windows for clarity.You disable issue-stale handling via
days-before-issue-stale: -1, but PR timings fall back to the action’s defaults (30days stale,7days to close). If different values are desired, add:- uses: actions/stale@v9 with: days-before-issue-stale: -1 + days-before-pr-stale: 45 + days-before-pr-close: 10This makes behaviour explicit and documents intent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/CODEOWNERS(1 hunks).github/workflows/codeql.yml(1 hunks).github/workflows/stale-pr.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/codeql.yml
22-22: the runner of "github/codeql-action/init@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
24-24: the runner of "github/codeql-action/analyze@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Code coverage
- GitHub Check: analyze
🔇 Additional comments (1)
.github/workflows/stale-pr.yml (1)
3-6: Cron schedule uses UTC 01:30 — confirm aligns with maintainer hours.Nothing wrong here, just ensure notifications/resolutions happen within your team’s working window.
nayrukii
changed the title
Description
This PR adds configuration updates to improve repository quality and security:
CODEOWNERSfile assigning @Thaleszh as the maintainer.stale-pr.ymlworkflow to automatically mark and close stale issues and pull requests.codeql.ymlworkflow to enable automated code scanning for security vulnerabilities.These changes are part of the repository hardening efforts to ensure proper review assignment, automated cleanup of old contributions, and vulnerability detection.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
These are configuration-level changes and do not affect runtime code directly.
CODEOWNERS.stale-pr.ymlandcodeql.ymlworkflows from the working setup inkiijs-sdk.No unit or integration tests are required for this PR.