-
Notifications
You must be signed in to change notification settings - Fork 24
Add tag_subscribers method
#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/ConvertKitAPIKeyTest.php
Outdated
|
|
||
| /** | ||
| * Test that tag_subscribers() throws a ClientException when an invalid | ||
| * tag ID is specified, as this is only supported using OAuth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment makes it seem like tagging with an invalid is possible with OAuth. Can we drop or modify the last clause? Same goes for the comments on the following functions in this file. I'm also wondering if these test are necessary since we're testing the specific behavior in ConvertKitAPITest.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can't be removed, as ConvertKitAPIKeyTest and ConvertKitAPIOAuthTest both extend ConvertKitAPITest, which is where most of the tests are contained (and therefore run) - otherwise, there'd be duplicate tests in two classes.
I've marked these methods to be skipped in ConvertKitAPIKeyTest, given testCreateTags checks for the ClientException.
Other redundant tests skipped in this PR.
noelherrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know on the inheritance constraints - after your explanation, it makes sense that you'd need to implement all parent methods.
Skip Redundant Tests
Summary
Adds a method for bulk tagging subscribers.
Testing
testTagSubscribers: Test thattag_subscribers()returns the expected data.testTagSubscribersWithInvalidTagID: Test thattag_subscribers()throws a ClientException when an invalid tag ID is specified.testTagSubscribersWithInvalidSubscriberID: Test thattag_subscribers()throws a ClientException when an invalid subscriber ID is specified.Checklist