Skip to content

Conversation

@roman01la
Copy link

@roman01la roman01la commented Jun 27, 2018

Tracking PR for #11

What've been done so far

  • Setup ClojureScript build
  • Setup testing for ClojureScript
  • Move shared code into schema-refined/core.cljc
  • Rewrite -def-map-type macro for ClojureScript (mostly protocols and interop)
  • Move Clojure & ClojureScript code for guarded structs into separate namespaces due to substantial differences
  • Adapt ClojureScript tests to host platform

More comments

  • cljs's -def-map-type macro is not entirely done yet
    • Not sure about JS interop yet (should it be js/Map or js/Object etc)
    • There's a bug somewhere that causes stack overflow in tests, haven't tracked it down yet
  • Schema coercion doesn't work as expected in ClojureScript, bc CLJS Schema extends js/Function type with its protocol which leads to different coercion results
  • Run tests with lein do clean, with-profiles dev,1.9 doo node test once (only Node for now, couldn't get it working on Nashorn)

@gsnewmark
Copy link
Member

Not sure it's worth spending time on Nashorn due to this http://openjdk.java.net/jeps/335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants