Skip to content

Conversation

@williamjallen
Copy link
Collaborator

The line and branch percentages were introduced in #3348 as text columns instead of numeric columns. This PR fixes the issue by casting the value to a float, allowing the values to be sorted numerically instead of alphabetically.

The line and branch percentages were introduced in Kitware#3348 as text columns instead of numeric columns.  This PR fixes the issue by casting the value to a float, allowing the values to be sorted numerically instead of alphabetically.
@williamjallen williamjallen force-pushed the coverage-sort-by-lines branch from f123b43 to ed78f56 Compare January 28, 2026 20:39
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Jan 28, 2026
Merged via the queue into Kitware:master with commit 6211fb6 Jan 28, 2026
12 of 14 checks passed
@williamjallen williamjallen deleted the coverage-sort-by-lines branch January 29, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants