Draft
Conversation
bnmajor
force-pushed
the
use-prompts
branch
2 times, most recently
from
da5791f to
e42320b
Compare
Replace text-based templates with structured YAML prompts following GitHub's schema. UI now loads model parameters directly from YAML files. Updates UI initialization to sync with YAML model parameters.
- CLI: vtk-prompt --prompt-file custom.yml - UI: vtk-prompt-ui --prompt-file custom.yml - Parameter hierarchy: CLI > custom prompt > defaults - Add RAG + UI integration with smart prompt selection
Replace monolithic YAML prompts with modular components for improved maintainability. - Implement PromptComponentLoader with LRU caching - Add VTKPromptAssembler with conditional composition - Single code path: custom prompts OR component assembly - Single source of truth for prompt composition - Keep specialized prompts (rag_chat, vtk_xml_generation)
- Centralize constants and eliminate code duplication - Remove unreachable code and simplify architecture - Optimize performance with LRU caching
Tests cover CLI/UI modes, RAG integration, parameter overrides, and error handling. Enhance documentation with model configuration guide, component system architecture.
Avoid lru_cache on instance methods. This retains "self" and can cause memory leaks.
Also moves load/download converstation file and download config file to the toolbar. Camera reset, clear scene, and tokens in/out have been moved to VTK Visualization component. Overall styling/spacing has been cleaned up for a more aligned, consistent layout.
Signed-off-by: Brianna Major <brianna.major@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch depends on #13
Support using the Github YAML prompt format for system defaults and user overrides:
--prompt-fileoption for YAML prompt loading from CLI and UIResolves #3